daKmoR / rocket

Move to https://github.com/modernweb-dev/rocket/
MIT License
13 stars 5 forks source link

Broken asset links on 404 pages #151

Closed bennypowers closed 3 years ago

bennypowers commented 3 years ago

When the page is a 404, asset links break:

consider https://wip-rocket.netlify.app/guides/themes/overriding/

<link rel="apple-touch-icon" sizes="180x180" href="assets/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="assets/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="assets/favicon-16x16.png">
<link rel="manifest" href="assets/webmanifest.json">

(note the relative links to ./assets)

Seems likely this is an issue with https://github.com/daKmoR/rocket/blob/0e5c89235702269b56c3ae765ad69b72773ff63b/packages/cli/src/shared/.eleventy.cjs#L40-L46

Possible fix: use existing filters: https://www.11ty.dev/docs/filters/#access-existing-filters

bennypowers commented 3 years ago

possibly related, I also get broken links to bundled script assets on some working pages, e.g.

<link rel="preload" href="../../../../4f51561b114.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../efa84054.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../01d85c72.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../8eb933f8.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../../6699b7a7114.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../../1cf01566114.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../f4b2844b.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../../76e8c71c66.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../6d56407e.js" as="script" crossorigin="anonymous">
<link rel="preload" href="../../../e94bddcf.js" as="script" crossorigin="anonymous">

../../../ vs ../../../../

see view-source:https://apolloelements.dev/guides/getting-started/codegen/typed-document-node/

this impacts page speed scores

daKmoR commented 3 years ago

we now have a dedicated 404 template you can use via

---
layout: 404.njk
permalink: 404.html
---