search

daKmoR / rocket

Move to https://github.com/modernweb-dev/rocket/
MIT License
13 stars 5 forks source link

Don't handle redirects in the Service Worker #152

Closed bennypowers closed 3 years ago

bennypowers commented 3 years ago

As per @thepassle, we should not handle redirects in the sw for an MPA, rather in the server, e.g. netlify.

see also https://blog.kiprosh.com/show-custom-404-error-page-for-netlify-applications/

bennypowers commented 3 years ago

See https://github.com/GoogleChrome/workbox/issues/2682#issuecomment-735992722

daKmoR commented 3 years ago

we no longer set a navigateFallback so servers are free to handle this now 👍