search

daKmoR / rocket

Move to https://github.com/modernweb-dev/rocket/
MIT License
13 stars 5 forks source link

WIP: fix: set the html classList as source of truth for theme switches #154

Open manolakis opened 3 years ago

manolakis commented 3 years ago

What I did

  1. set the html classList as source of true for the dark mode switches. This fixes the problem toggling the dark mode resizing the window.

https://user-images.githubusercontent.com/329771/103251266-6f787300-4978-11eb-93f0-63467af48aee.mp4

  1. apply a filter on dark mode to reduce the white brightness.
  2. apply dark mode on search.

https://user-images.githubusercontent.com/329771/103321954-651fad00-4a3c-11eb-83c0-79ab80083a91.mp4

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: e1168b2f2d542d19de499ce1ed9a8b752fbe9109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @d4kmor/launch | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR