search

daKmoR / rocket

Move to https://github.com/modernweb-dev/rocket/
MIT License
13 stars 5 forks source link

fix: allow inputDir configuration, and update unit test #158

Closed gdbaldw closed 3 years ago

gdbaldw commented 3 years ago

What I did

  1. Wrote test demonstrating that normalizeConfig failed to update inputDir from rocket.config.js
  2. Fixed normalizeConfig, so that the test passes.
  3. User tested with { inputDir = "doc-dir/my-docs" }, including live updates. Success!
changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: da6881ba0661c2124013984a5186f6cba691a9e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gdbaldw commented 3 years ago

Closes #159

daKmoR commented 3 years ago

thank you for reporting and diving into it... I'm however currently simplifying and modifying the config a lot 😅 (seems we did run into a bad timing 🙈 )

I will make sure to incorporate this feature 👍

gdbaldw commented 3 years ago

@daKmoR Just a one line fix, one line test. Seems robust. Hoped it useful to you until the rewrite. I'll be using it.

daKmoR commented 3 years ago

I already had the code changed locally 😅

thx again for looking into it - it's however superseded by https://github.com/daKmoR/rocket/pull/156