search

daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
716 stars 57 forks source link

Doesn't detatch from running console #111

Closed hasufell closed 6 years ago

hasufell commented 6 years ago

gvim used to detach from the running console. I think this is largely desired behavior, no?

hasufell commented 6 years ago

I have written a patch here.

You can fetch it like this (sorry, I don't like github).

git fetch https://gogs.hasufell.de/hasufell/neovim-gtk.git daemonize

This utilizes the unix-daemon package.

daa84 commented 6 years ago

Ok, looks good, but it must also be compiled on windows

hasufell commented 6 years ago

Ok, looks good, but it must also be compiled on windows

Hmm, how do I test that it does? Just ifdef for linux?

daa84 commented 6 years ago

it must be something like this https://github.com/daa84/neovim-gtk/blob/21e74c7ca7468a53ce1cbb449a19b8144f06836f/src/settings.rs#L26 #[cfg(unix)] on top of line or method just cut it from windows build currently it does not build on windows

hasufell commented 6 years ago

branch updated, please fetch again and try

daa84 commented 6 years ago

merged to master, thanks