search

daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
716 stars 56 forks source link

[RFC] unset decorated flag when NVIM_GTK_NO_HEADERBAR=1 #140

Closed ammen99 closed 6 years ago

ammen99 commented 6 years ago

This is actually a small change and ensures that there are no decorations when headerbar is disabled. Is this the intended behavior? Or maybe this should be a different option altogether?

daa84 commented 6 years ago

As I don't use this flag hard to say what is use case for it. So i can just merge this pr as is if there no comments here :smiley:

unclechu commented 6 years ago

I think it could help window managers to do some stuff depending on it, am I right?

ammen99 commented 6 years ago

Maybe, I'm not sure what GTK does internally with this. But I know it disables client side decorations on wayland. Otherwise, without this PR, I don't get the headerbar, but a simple decoration around the window instead. But I want to have an option to have a simple full-window render of neovim (of course I can just patch neovim-gtk, but I thought maybe others wanted this too)

daa84 commented 6 years ago

Think in most cases this remove window title bar created by window manager.

ammen99 commented 6 years ago

In wayland, most clients have built-in decorations. In that case, this disables them. I'm not sure about X, but probably it is as you said.

daa84 commented 6 years ago

For me it looks ok. If will be any other comments we can split to two different flags