daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
716 stars 57 forks source link

Don't use -i option for sed to make it more compatible with non-GNU sed. #168

Closed mcepl closed 5 years ago

mcepl commented 5 years ago

Also, add missing .PHONY target. Also, in my opinion a text editor has no business to install fonts to my system. If we require a font, then we should say so in README, or raise an error when it is missing, but not install it on our own.

Fixes #164

daa84 commented 5 years ago

Yes, think font can be removed, not sure why i add it, maybe because same was in neovim-qt Does current solution will work if in $PREFIX will be /? /usr/local. Use of | was because of this

mcepl commented 5 years ago

Actually, non-/ characters delimiting paramters of s command are POSIX, so we can use it.

alerque commented 5 years ago

Non GNU-sed can actually handle the -i parameter just fine, but what it can't handle is typically the expression bungled in after it that isn't the optional backup file name parameter -i can take. If you specifically note the expression with the -e flag it works fine. Next time try sed -i -e instead.

Obviously this time in the event of needing a different output file anyway the inline edit is necessary to start with, but using the -e flag is still a good idea.

mcepl commented 5 years ago

@alerque you are obviously right.

daa84 commented 5 years ago

Thanks