daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
716 stars 57 forks source link

About dialog should show actual build version, not next tag #191

Closed alerque closed 5 years ago

alerque commented 5 years ago

The current "about" dialog box shows a as of yet non-existent version number (currently 0.2.0). Besides just being plain confusing, this makes it tricky to report bugs.

When building from a release tarball or a tagged git commit, the tagged version should be used. When building from any other commit, the last know tag should be shown, plus the hash of the current commit and some indication of the progress (usually a counter of commits since the last tag).

In fact the easiest way to do this is have something in the make file that reads git describe --tags --always to set the version string. For example right now the output of that is v0.1.1-450-gc8b11cb, which would be an imminently useful string to see in the about dialog as the version string.