daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
718 stars 56 forks source link

Show filename and dir in header bar #63

Closed christopher-l closed 6 years ago

christopher-l commented 6 years ago

I also included some changes to the header bar, that I hoped would be uncontroversial. I think "Open" with an arrow and "Save All" are much clearer than symbols. In the long run, I think a hamburger menu would be sensible, but yet there is nothing to put there.

I am not sure about my subscription approach. It has the downside, that it can be broken by disabling the autocmds. There is also Neovim's subscribe method, but I couldn't figure out if that could solve this or how to use it.

daa84 commented 6 years ago

Need some time to read code 😄 nvim_subscribe - is something strange for me, looks like it used only for rpcnotify. Also in latest neovim builds there is some new events that pass options to gui when they changed, maybe current path here also exists, can't say, in this case it simplify code. But I'm not sure

daa84 commented 6 years ago

Thanks Like how it looks :+1: