search

daa84 / neovim-gtk

gtk ui for neovim
GNU General Public License v3.0
716 stars 57 forks source link

[Windows] No icon on AppVeyor build #93

Closed Anrock closed 5 years ago

Anrock commented 6 years ago

It would be nice if neovim-gtk had some icon. I've associated all my text files with neovim-gtk and they look like generic executable icon which is confusing. Until there is no branded neovim-gtk icon i guess it's fine to use generic neovim icon like that: https://commons.wikimedia.org/wiki/File:Neovim-mark-flat.svg https://commons.wikimedia.org/wiki/Category:Neovim#/media/File:Neovim-mark.svg

daa84 commented 6 years ago

It already used and installed together with desktop file with make install. https://github.com/daa84/neovim-gtk/blob/bda35efe8810f7cfab9c56778f9dd7cb066425c2/Makefile#L21

Anrock commented 6 years ago

@daa84 i see, i thought there is no icon at all. There is no icon on AppVeyor builds. Renamed issue accordingly.

Anrock commented 6 years ago

@daa84 ping

Anrock commented 5 years ago

@daa84 ping

daa84 commented 5 years ago

As i don't know how icons works in windows, it will be helpful to have link to description or link to how to add it appveyor build or rust specific logic. Maybe some rust project already have such function so we can look at it?

So to speedup develop any issue in case you can't provide pr it is better to support it with some info on how to better implement it.

Anrock commented 5 years ago

@daa84 thank you!