Bug : Suddenly colorschemes aren broken

[Zardoz89]

The last commits (not hapens on commit bda35ef ) has broken vim colorschemes :

This happens with monokai-phoenix and with darkblue (included on all vim/neovim) color scheme

To reproduce :

" Color mode
if (has("termguicolors"))
  set termguicolors       " TrueColor!
else
  set t_Co=256            " 256 color mode in term
endif

set background=dark
" colors monokai-phoenix
colors darkblue

Monokai-phoenix:

Darkblue:

[daa84]

Ah, looks like problem only when NVIM_GTK_DOUBLE_BUFFER=1

[Zardoz89]

@daa84 It isn't fixed! Keep happening with the last commit.

[daa84]

did you use NVIM_GTK_DOUBLE_BUFFER=1 ?

[themayarose]

I experience this issue with both NVIM_GTK_DOUBLE_BUFFER on and off.

EDIT: This happens on commits 544 and 545; on 542 it's working fine.

[Zardoz89]

@daa84 I just try with the last commit and with NVIM_GTK_DOUBLE_BUFFER=1 . Works correctly.

@ugopozo Better try to paste commit hash instead of numbers.

[daa84]

@Zardoz89 c56c945f025a9350a8e99ab4b77c447ff35f9966 does change something? NVIM_GTK_DOUBLE_BUFFER=0 does not work?

[themayarose]

On c56c945 (commit 546) NVIM_GTK_DOUBLE_BUFFER=1 fixes the issue. Yay!

However, with the double buffer set to zero, the colors still appear off. But IIRC the double buffering setting is supposed to force the default behavior when for some reason it's disabled, right? So maybe it can be considered fixed for now.

[daa84]

NVIM_GTK_DOUBLE_BUFFER do some small performance impact. Also in my local installation i don't have any problems without NVIM_GTK_DOUBLE_BUFFER, so it is disabled by default 😄 But maybe it is good idea to enable it.

[Zardoz89]

@Zardoz89 c56c945 does change something? NVIM_GTK_DOUBLE_BUFFER=0 does not work?

Keeps happening.

NVIM_GTK_DOUBLE_BUFFER do some small performance impact. Also in my local installation i don't have any problems without NVIM_GTK_DOUBLE_BUFFER, so it is disabled by default smile But maybe it is good idea to enable it.

But, why this happening ? Why disabling/enabling double buffering affect this ? It's related to a Gtk bug ?

[daa84]

Looks like gtkdrawingarea surface in some configurations (or gtk version) created without alpha channel. Don't know why.

[YaLTeR]

Also started hitting this issue, NVIM_GTK_DOUBLE_BUFFER=1 seems to fix it.

[maorv]

reverting below commit seems to fix the issue (at least on ubuntu 18.04)

commit 2dc10aa6110aa17d72554c82c9f0676f3d5609a2 Merge: df04e7d 8216cfb Author: daa andrey.dubravin@gmail.com Date: Sun May 6 13:00:21 2018 +0300

Merge branch 'cursor-color' (#43)

[daa84]

NVIM_GTK_DOUBLE_BUFFER removed with 21e74c7ca7468a53ce1cbb449a19b8144f06836f , must issue must be fixed