search

daa84 / neovim-lib

Rust library for Neovim clients
GNU Lesser General Public License v3.0
192 stars 26 forks source link

Feature/unix sockets #3

Closed boxofrox closed 7 years ago

boxofrox commented 7 years ago

I rebased and preserved @mikezaby's commit from #1, added conditional macros to compile unix_sockets support on unix-based OS's, and included a unit test.

Also replaced try! macros per the rustfmt.toml.

Tested.

boxofrox commented 7 years ago

Doh, neovim isn't installed in the TravisCI test environment and ubuntu precise doesn't have a neovim package in its repository. I can #[ignore] the unit test, or do a bit of research to tweak the travis.yml to install neovim in the build environment.

daa84 commented 7 years ago

Hello! thanks. for me ignore is ok :) also std::path::Path; is used only in unix code, so maybe add cfg(unix) to it, to mute warning?

boxofrox commented 7 years ago

sounds good. added ignore to test for now, and cfg(unix) to std::path::Path.

mikezaby commented 7 years ago

@boxofrox nice and sorry for that I left the previous PR incomplete.

boxofrox commented 7 years ago

...and I missed use std::path::Path in test/lib.rs. Moved that inside the test and now it's cfg(unix), too.

daa84 commented 7 years ago

Thanks