Create a .sublime-syntax and use `embed` to embed JS in it

daaain / Handlebars

Fullest Handlebars.js templating support for Sublime Text 2 / 3. Also drives syntax colouring on Github and in Visual Studio Code. Install from: https://packagecontrol.io/packages/Handlebars.

MIT License

301 stars 48 forks source link

Create a .sublime-syntax and use `embed` to embed JS in it #111

Closed MatthiasPortzel closed 8 months ago

MatthiasPortzel commented 10 months ago

Per discussion in #110.

I'll update this PR or make a new PR with README and documentation changes later (depending on my availability), but this is the main fix.

daaain commented 10 months ago

I cloned this to ~/Library/Application Support/Sublime Text 3/Packages/User/Handlebars for testing – had to remind myself how to do development on the package 😅

The good thing is that apparently ST4 takes over that ST3 folder so it's easy to share settings and the package.

Seems to work in both versions when looking at the test file.

ST4:

ST3:

I'm happy to merge this and have a new version going out so more people can test it and as you say we can update the documentation if / once it's working fine?

MatthiasPortzel commented 9 months ago

@daaain I've added a sentence to the README in this PR. I think it's ready to be merged and updated on Package Control.

I just want to avoid bike-shedding the README wording here because there are a number of other updates that should be made to the README.

daaain commented 8 months ago

README addition sounds good, sorry for the delay and thanks for your contribution, merging and releasing now!

MatthiasPortzel commented 7 months ago

I just wanted to say thanks for merging this; I'm using the version from package control and it's working great.