daaain / Handlebars

Fullest Handlebars.js templating support for Sublime Text 2 / 3. Also drives syntax colouring on Github and in Visual Studio Code. Install from: https://packagecontrol.io/packages/Handlebars.
MIT License
301 stars 48 forks source link

Drop '-template' from x-temp snippet's type declaration #28

Closed bsradcliffe closed 10 years ago

bsradcliffe commented 10 years ago

I believe that 'text/x-handlebars-template' is only used in the case of defining templates that do not make use of the 'data-template-name' attribute.

bsradcliffe commented 10 years ago

Yes, this is for Ember. See here: http://emberjs.com/guides/templates/handlebars-basics/

I tweeted at Kevin Decker (Handlebars.js maintainer) for confirmation but haven't heard back yet. The large majority of walkthroughs and apps I've seen thus far only instantiate a type declaration with 'x-handlebars-template' when making use of the template via its 'id' attribute. I wish there was a more solid documentation on this, but Handlebars.js and Ember.js need some work in that regard.

bsradcliffe commented 10 years ago

@daaain, no update from Katz or Decker, but every site I've seen the code on and the Ember.js site itself is using type='text/x-handlebars" data-template-name="foo".

daaain commented 10 years ago

No one objected here either, so good to go :)