Weird behavior on block helper attributes

[victorwpbastos]

I'm having weird colors on block helpers attributes:

Inline helpers is normal. In block helpers only the first attribute is colored fine. Any ideas?

[daaain]

Good spot, added a test case to cover it:

[hlvnst]

I'm on a roll lately.

@daaain Question: do you tag releases directly using Git or using apm publish?

[daaain]

@hlvnst you're a :star:

I use apm publish, mostly patch for these small incremental fixes.

[daaain]

What am I talking about with "small incremental fix", this actually seems to also have solved named block parameters and array notation :)

Before

After

[hlvnst]

I noticed that at least named parameters incidentally improved with this fix (see commit message). Hadn't noticed the same for array notation, though. Good catch.

Rather fortuitous, I wish all fixes were that easy.

I'll try apm publishing from this end, see if that works...

[hlvnst]

Well, that only worked halfway:

Preparing and tagging a new version ✓
Pushing v1.4.0 tag ✓
Publishing Handlebars@v1.4.0 ✗
Creating new version failed: Git tag not found

It didn't push the tag upstream (to this repo), only to my fork. I pushed the tag here manually, but Atom doesn't seem to pick that up.

[daaain]

Hmm, in theory you should have rights to publish the package if you can push to the repo: https://atom.io/docs/v1.4.0/behind-atom-maintaining-your-packages#adding-a-collaborator

I do it while being on the main repo master branch, it think it'll only work from there not the fork.

[hlvnst]

it think it'll only work from there not the fork

That seems to be the case. Next time, I'll just clone this repo to apm publish from. That should do the trick.