daangn / kinesumer

A Go client implementing a client-side distributed consumer group client for Amazon Kinesis
Apache License 2.0
76 stars 6 forks source link

fix: update checkpoint when cancel subscription on efo mode #10

Closed proost closed 2 years ago

proost commented 2 years ago

If canceled in the middle of time interval, not update check point.

I want to add test case. but it is hard to add test case for efo mode. because with localstack kinesis, subscription not work correctly.

If you care about test case in this case, tell me a advice

mingrammer commented 2 years ago

I think it seems more like bug fix or refactoring rather than feature addition.