fix(core, plugin-history-sync): accept only serializable parameters

daangn / stackflow

🧱 Mobile-first stack navigator framework with composable plugin system

https://stackflow.so

MIT License

747 stars 80 forks source link

Closed tonyfromundefined closed 2 months ago

tonyfromundefined commented 2 months ago

I discovered the possibility of passing an object with circular dependency to activity.context, so there was logic to delete the activity.context to make it serializable before assigning it to history.state.
There was a case where activity.context was utilized in user land. In this case, the stability of the activity.context field must be guaranteed.
After thinking about it further, I realized that the event itself is serializable, so I changed the makeEvent() function to check for serializability and deleted the logic to delete the activity.context.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
stackflow-docs	✅ Ready (Inspect)	Visit Preview	Jul 9, 2024 8:24am

changeset-bot[bot] commented 2 months ago

Latest commit: d792d872761b7934e7ebdb25d53e79b804d09f0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------------ | ----- | | @stackflow/plugin-history-sync | Patch | | @stackflow/core | Patch |