daangn / stackflow

🧱 Mobile-first stack navigator framework with composable plugin system
https://stackflow.so
MIT License
782 stars 84 forks source link

Sentry tracing integration #520

Open XiNiHa opened 1 month ago

XiNiHa commented 1 month ago

There are various Sentry integrations for SPA routers with tracing support, a TanStack Router integration for example. Having one for Stackflow would be very helpful for Sentry users. Since we already have event-driven plugin architecture, I guess it'd be pretty straightforward to make a plugin for it.

tonyfromundefined commented 1 month ago

Thanks for the great suggestion Xiniha!

I've had a quick look at it, but I'm not sure what the benefits of integrating router framework with Sentry would be. It looks like it adds navigation tracing, but would that be a big help in tracking errors?

https://github.com/getsentry/sentry-javascript/blob/de9cf8a30b61c652264610a31d0c8322748cb46d/packages/react/src/tanstackrouter.ts#L78-L85

XiNiHa commented 1 month ago

I believe it can be helpful for both performance monitoring and debugging.

tonyfromundefined commented 1 month ago

Okay, that makes sense now that I understand the situation “history sync extension can't be used”. I think it's a good suggestion, and since we don't have the resources right now, I'd be happy if you could contribute to it yourself

XiNiHa commented 1 month ago

I'll look into it when I get some spare time 😅 If anyone is interested in the feature, let me know so I can bump up the priority!

ysh4296 commented 1 week ago

@XiNiHa @tonyfromundefined

Hello! im interested in this issue

I already made minimal version of sentry plugin for stackflow and tested it with local server & sentry. seems working properly!

If no one else is currently working on this issue can i try this feature?

XiNiHa commented 1 week ago

Sounds great 👍