Rectangle primitive broken

daanmichiels / igl-hr

Hyperbolic space on the Oculus Rift

3 stars 0 forks source link

Rectangle primitive broken #5

Closed daanmichiels closed 9 years ago

daanmichiels commented 9 years ago

In commit 4969367ac7668a857dd5d03a9db7beb9ae3b667f, it seems that the rectangle primitive is broken. Increasing the length of the rectangle (hr.cpp, line 88, change 2.0 to 8.0) makes it narrower.

daanmichiels commented 9 years ago

I just rewrote the rectangle primitive from scratch, and the phenomenom persist. Maybe the problem is with the exponential map hypermath::exp0.

daanmichiels commented 9 years ago

Is this still an issue?

daanmichiels commented 9 years ago

Kyle, could you check whether this is still present?

mcdaniel67 commented 9 years ago

It is still present. I will look into fixing this issue.

daanmichiels commented 9 years ago

Status?

mcdaniel67 commented 9 years ago

This is still broken. I've tried a couple different methods to fix this using GL_TRIANGLES, GL_QUADS, and GL_TRIANGLE_FAN last semester, but I never got the issue fixed. I have a few more ideas of things to try.

mcdaniel67 commented 9 years ago

The bug was in our intuition, not in the programming. We can see this by making the rectangle extremely small, thus making the curvature near euclidean. This made the rectangles appear correctly.