search

daanmichiels / igl-hr

Hyperbolic space on the Oculus Rift
3 stars 0 forks source link

Incorrect translations in CameraControls #7

Closed daanmichiels closed 9 years ago

daanmichiels commented 9 years ago

The translations for walking around (WASD) in /src/cameracontrols.cpp are incorrect. The way they are currently written, they are not even isometries of hyperbolic space (the translation is from the origin to a point that's not in the hyperboloid -- presumably a forgotten call to exp0). But even then, the translation should be relative to the camera's current position and orientation.

kwrobes commented 9 years ago

I just doublechecked our hypermath file and the transformation there is correct. I'll proceed to muddle through the camera controls.

kwrobes commented 9 years ago

Well, I just saw the problem to which you are referring and I'll add some stuff to the camera class for tracking it's position. It'll be a quick fix since roundoff error will still push it out of our space eventually.

kwrobes commented 9 years ago

Should be fixed. Added a new position variable to camera in order to track positions. Not sure if it looks like hyperbolic space but distortions are clear when rotating mouse. Also, when moving the lines along which you move are geodesics. So that's nice. I believe this is closed.

daanmichiels commented 9 years ago

This isn't fixed. I start the program. I walk forward, through the grid of tetrahedra. I turn 180 degrees to the right, so that I face the grid again. I press forward. I start moving to the right....

kwrobes commented 9 years ago

Yeah I'm going to change those this morning On Oct 9, 2014 10:18 PM, "Daan Michiels" notifications@github.com wrote:

This isn't fixed. I start the program. I walk forward, through the grid of tetrahedra. I turn 180 degrees to the right, so that I face the grid again. I press forward. I start moving to the right....

— Reply to this email directly or view it on GitHub https://github.com/daanmichiels/igl-hr/issues/7#issuecomment-58608008.