search

daannijkamp / tunnelblick

Automatically exported from code.google.com/p/tunnelblick
0 stars 0 forks source link

Memory leak #171

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
in tunnelblick/MenuController.m:
myConfigDictionary = [[[[ConfigurationManager defaultManager] 
getConfigurations] mutableCopy] retain];

"mutableCopy" already retains, so you are retaining twice, causing a memory leak

Original issue reported on code.google.com by spoon.re...@gmail.com on 20 Jan 2011 at 6:54

GoogleCodeExporter commented 9 years ago 
Thanks. I'll fix it.

There isn't really a leak, though. MenuController is the "main" class for 
Tunnelblick and only has one instance. When it goes away, the entire program 
goes away, and all memory allocated by it is released.

Original comment by jkbull...@gmail.com on 20 Jan 2011 at 11:36

GoogleCodeExporter commented 9 years ago 
Fixed in the source code in r1340

Original comment by jkbull...@gmail.com on 3 Feb 2011 at 10:21