daanx / mimalloc-bench

Suite for benchmarking malloc implementations.
MIT License
375 stars 55 forks source link

Failure to build pa because of missing source file for ninja #202

Open nightduck opened 8 months ago

nightduck commented 8 months ago

System

Ubuntu 22.04

Error

...
ninja: Entering directory `out/Default'
ninja: error: '../../third_party/libc++/src/src/algorithm.cpp', needed by 'obj/buildtools/third_party/libc++/libc++/algorithm.o', missing and no known rule to make it

Steps to reproduce

git clone git@github.com:daanx/mimalloc-bench.git
cd mimalloc-bench
./build-bench-env.sh all

This bug occurs on this line in the build script https://github.com/daanx/mimalloc-bench/blob/a45c31e31b093c25cd12a431398c7538ef8584f4/build-bench-env.sh#L528

The setup_packages function ran correctly and ninja-build did get installed

nightduck commented 8 months ago

Commenting out setup_pa yields an error in setup_tcg, because gawk is not installed

https://github.com/daanx/mimalloc-bench/blob/a45c31e31b093c25cd12a431398c7538ef8584f4/build-bench-env.sh#L581

nightduck commented 8 months ago

After adding gawk to the list of apt-get install packages, everything else builds correctly https://github.com/daanx/mimalloc-bench/blob/a45c31e31b093c25cd12a431398c7538ef8584f4/build-bench-env.sh#L417-L420

jvoisin commented 8 months ago

Can you please send a pull-request fixing this? <3

nightduck commented 8 months ago

I can submit a PR with the gawk fix, but I don't know how to fix the autoninja line failing

luzhixing12345 commented 8 months ago

the same issue for me, use no-pa in args flags to skip building pa for now

caizixian commented 1 month ago

This was caused by https://github.com/1c3t3a/partition_alloc_builder not pinning the upstream commits, and getting out of sync after this commit https://github.com/chromium/chromium/commit/35902f7433df844ff383a8a6ab04dd1682770b4c