search

daanzu / kaldi-active-grammar

Python Kaldi speech recognition with grammars that can be set active/inactive dynamically at decode-time
GNU Affero General Public License v3.0
339 stars 51 forks source link

add python dependencies #27

Open dwks opened 4 years ago

dwks commented 4 years ago

I just installed kaldi-active-grammar on a new system. The prebuilt pip package didn't depend on sounddevice and webrtcvad, and I got runtime errors from my grammar until I installed them. It would be good to list these as python dependencies in the pip package, assuming they would be required by any grammar.

daanzu commented 4 years ago

kaldi-active-grammar doesn't depend on those, since it is supposed to be agnostic as to the source. If using dragonfly, I think they should be installed with pip install dragonfly2[kaldi].

dwks commented 4 years ago

Yes, this works. Please consider adding this to the README, it's pretty confusing to start using kaldi-active-grammar on Linux currently. P.S. pip install dragonfly2[kaldi] pulls in kaldi-active-grammar automatically.

dwks commented 4 years ago

If you don't want to mention dragonfly on the kaldi-active-grammar page, could at least mention it here: https://github.com/daanzu/kaldi-grammar-simple

daanzu commented 4 years ago

I should definitely make this more clear. Thanks for pointing it out!