search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

default images for missing covers for person and org #156

Closed josefspr closed 7 years ago

josefspr commented 8 years ago

Mushon can you make them ?

mushon commented 8 years ago

Sure @yuvadm what size and format do you want me to use?

yuvadm commented 8 years ago

50x50 and 320x214

mushon commented 8 years ago

50x50 icons attached (both normal and retina). Please do not use an image in the card if one does not exist. Thanks!

ico-institution-def ico-institution-def 2x ico-person-def ico-person-def 2x

josefspr commented 8 years ago

It looks very nice but don't you feel its quite militant... ?

mushon commented 8 years ago

Here's another more abstract option:

Person: ico-person-def ico-person-def 2x

Org: ico-institution-def ico-institution-def 2x

josefspr commented 8 years ago

Are we also talking about the default image appearing in the person/org card ? the format is rectangular landscape, no ? Org is nice, person maybe a less abstract, but its your call

mushon commented 8 years ago

These images will only appear in the search autocomplete. In all other cases the card will appear with no image of none is submitted.

josefspr commented 8 years ago

Does'nt the card without the image look unbalanced ?

mushon commented 8 years ago

I don’t think so, but let’s See it implemented and decide, maybe we will use a background color or something later. But I don’t think it will be needed.

talbenbasat commented 7 years ago

HI,

@mushon can you please resend the final images to place in the cards

thanks, Tal

mushon commented 7 years ago

@talbenbasat please use the images above.

Person: ico-person-def ico-person-def 2x

Org: ico-institution-def ico-institution-def 2x

talbenbasat commented 7 years ago

@mushon ,

Cant extract the assets from invision https://projects.invisionapp.com/d/main#/console/5753463/169569780/preview

Tal