Display Copyrights info of images and sounds

[josefspr]

Image copyrights in lightbox Sound copyrights in event card (sound control)

[josefspr]

@mushon can you complete this one this week ? I need it to prepare Tal's next milestone. It can just be a button on the enlarged image and sound player that opens a model text box.

[mushon]

done here: https://invis.io/6EAF4PJFU

Please note that on the project cards the credit will appear under the scroll

[josefspr]

the copyrights is not a single line but is a retailed info window, so I think we need a popup e.g. https://daat-hamakom-data.herokuapp.com/admin/maps/media/814/change/

[mushon]

I think it would be better to use a dropdown for the copyright type and then use an icon to represent it like they do in Vimeo for example:

[mushon]

We may also want to include both a link to the author and a link to the image like this:

[josefspr]

This can be a solution and we have to decide any case regarding the license type. for the the sound files you meant to put it on bottom of event card after description ?

[mushon]

Like this: https://invis.io/HC6EQ6L7Q#/216214397_New-Timeline-3_Copy_7

[josefspr]

looks fine

[talbenbasat]

@mushon,

we cant change the player entirely.

https://daat-hamakom-staging.herokuapp.com/#/project/4/event/36?_k=dg86pc

How do you think we should solve the design based on the existing player

Tal

[mushon]

why not use jplayer.org or some other solution like it that allows styling?

[mushon]

in general, there are tons of solutions that do that

[talbenbasat]

@josefspr its your decision but it wasn't in the original task

[talbenbasat]

@mushon regarding the lightbox there is a problem when the image is light in the bottom

[talbenbasat]

as you can see the title contrast isn't good

[mushon]

Please note the linear gradient on the image:

[talbenbasat]

@mushon Ok

looks good with it :+1:

Is there a chance to replace the font of the copyright to something else.

now it's font-family: "Arial Cyr MT"; Its not a basic or google font and I would prefer it to be.

[mushon]

Yes. It's a mistake. The font should be Merriweather Sans like all the rest of the interface.

[josefspr]

some lightbox images are too big https://daat-hamakom-staging.herokuapp.com/#/project/11/event/304?_k=ms9h5x https://daat-hamakom-staging.herokuapp.com/#/project/11/event/303 some too small https://daat-hamakom-staging.herokuapp.com/#/project/11/event/302

[josefspr]

when media source is empty, there should not be a link and hand on source. https://daat-hamakom-staging.herokuapp.com/#/event/302?_k=h1bhin clicking on source takes me to another copy of map

[josefspr]

@mushon don't you think adding gradient to image is distorting - e.g. a poster https://daat-hamakom-staging.herokuapp.com/#/project/21/event/1040

[josefspr]

regarding the player. For this milestone lets work will current player and put title above and copyrights underneath. If we'll have additional hours to spend we'll try replacing.

[josefspr]

if there is a single image, arrows of lightbox should not appear

[talbenbasat]

Hi @josefspr,

The too big will be solved. All of the images are at maximum the image size.

Talk to me again about the copy right so i'll create the right conditions with you.

Any case I've uploaded a new version of the lightbox Please talk to me when you are available

Tal

[josefspr]

Regarding caption look at this

I think text should be justified to left. @mushon, I also think the caption is too contrasting to copyrights.

[josefspr]

@mushon, is there a difference between appearance of word "source" when there is a link to it or only a tooltip ?

[mushon]

when there is no link the underline is dashed. otherwise the link is solid

[mushon]

The caption overlay in the lightbox doesn't work. I simpler way to do it here: https://invis.io/HC6EQ6L7Q#/226905063_Lightbox