search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

Thumbnails missing correcting bad media #213

Closed josefspr closed 7 years ago

josefspr commented 7 years ago

@talbenbasat here is a consistent script: attach to an event a media item with a bad file type (eg. xlsx) see on map that thumbnail is missing replace the media bad file with a good one (jpg) thumbnail is still missing

talbenbasat commented 7 years ago

@josefspr,

Can you please enhance

talbenbasat commented 7 years ago

pushed a basic bugfix Please verify that its working

josefspr commented 7 years ago

I think its not fixed, fix was supposed to display this missing thumbnail https://daat-hamakom-staging.herokuapp.com/#/event/31

talbenbasat commented 7 years ago

Got it fixed and pushed

josefspr commented 7 years ago

cool!

josefspr commented 7 years ago

@tal still not fixed in some cases https://daat-hamakom-staging.herokuapp.com/#/event/1106

talbenbasat commented 7 years ago

@josefspr it is not retroactive

You have to reupload the image to trigger the process

josefspr commented 7 years ago

I reuploaded this but still https://daat-hamakom-data.herokuapp.com/admin/maps/media/911 https://daat-hamakom-staging.herokuapp.com/#/event/1106

talbenbasat commented 7 years ago

The name of the image must change in order for it to work

Without a change in the name the object isn't considered as changed

josefspr commented 7 years ago

@talbenbasat can you change uploaded filename to make it unique ?

talbenbasat commented 7 years ago

Already done

On Sun, Jul 9, 2017 at 4:25 PM, josefspr notifications@github.com wrote:

@talbenbasat https://github.com/talbenbasat can you change uploaded filename to make it unique ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daat-hamakom/maps/issues/213#issuecomment-313919780, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlTMHxn2c60eYPskvpSWXNYBxSw5m91ks5sMNTAgaJpZM4NvT7n .

-- Tal Ben Basat Software Architect 0528-428-598 appandup.co.il

josefspr commented 7 years ago

can you check this one: https://daat-hamakom-staging.herokuapp.com/#/person/128 https://daat-hamakom-data.herokuapp.com/admin/maps/media/478