search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

Close current event card on filter change #216

Closed josefspr closed 7 years ago

josefspr commented 7 years ago

When a filter context is changed, current open card should close only if event does not belong to filter.

talbenbasat commented 7 years ago

@josefspr,

please define a coherent logic for closing the event card

josefspr commented 7 years ago

Close current event card when selecting Filter only if current event is NOT part of this context.

talbenbasat commented 7 years ago

@josefspr

you mean the event card on the side, right?

josefspr commented 7 years ago

yes

talbenbasat commented 7 years ago

Hi @josefspr ,

The second option causes problems in the map So i just did the first option

I dont close the event card when the link is from the event card

josefspr commented 7 years ago

@talbenbasat its ok that the card stays open on filters opened from event card. When I open filter from search or cards view sometimes event cards is closed and sometimes open, should be consistent and always close.