search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

Associated filters do not match the design #224

Closed mushon closed 7 years ago

mushon commented 7 years ago

This is how they should look: uploads/8afdbc27-cdb8-4af6-876f-420ebb2129ba/image.png

This is how they currently look:

uploads/1b44d0b2-9040-4fa4-b615-9f21ee0ff6f6/image.png

talbenbasat commented 7 years ago

@josefspr,

The events JSON doesn't contain the person image. we can:

  1. add the image to the events JSON - increase its size
  2. search in the people JSON and get the image from there - consume processing time

Which one would you prefer?

josefspr commented 7 years ago

not so happy about 1, regarding 2 - what might it slow down ?

talbenbasat commented 7 years ago

@josefspr Now we have to search the people in the client-side DB, when we display the event card

josefspr commented 7 years ago

@tal the right corners of the rectangle should be rounded

talbenbasat commented 7 years ago

@josefspr it is - 5px

Changed to 15px to make it more rounded