search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

Contract button should be attached to search bar #227

Closed mushon closed 7 years ago

mushon commented 7 years ago

Designed: uploads/75d3dc51-253e-461f-be45-1fb3f32289da/image.png

Currently: uploads/61ce089c-9148-4b6c-8896-e64e9e5d4958/image.png

Also please note that in both cases (both open and closed) the button should not have a bottom border and should only reveal the upper half of the circle.

josefspr commented 7 years ago

@talbenbasat please replace direction of arrow on button also on selecting search card or text.

talbenbasat commented 7 years ago

The direction of the arrow is based on if the metacard is open or not

josefspr commented 7 years ago

@mushon I am not sure whether contract button also replaces the close button on the search bar. @talbenbasat says that the contract button is only for opening and closing meta-cards, while the close X on right side is to close the search bar. If this is correct, we should locate contract button a bit more to the left because they don't look good close together.

mushon commented 7 years ago

They should never appear together. There is no reason to see the expand bar when we're in the filter view: image

And there is no need to see the close button when we're on a meta-card: image

The X on meta cards that is attached to the filter has a different meaning than the X in the search bar, as it removes the filter.

I hope this helps clarify.

josefspr commented 7 years ago

@talbenbasat the X still appears when onboarding and cards view is open. X appears on card view (correct) but should also appear on search to be consistent.

josefspr commented 7 years ago

@mushon should right side close (X) also appear on text search bar ?

mushon commented 7 years ago

Yes, it is the expand button that should not appear there.