search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

timeline labels are mispositioned #228

Closed mushon closed 7 years ago

mushon commented 7 years ago

Should be slightly higher: uploads/2dfb402b-17b2-43e6-8a20-488d758f3c9c/image.png

And they're missing their 3px rounded corners and they should be slightly larger than they currently are: uploads/eabdfcfe-6a55-4a08-8e90-4562263a5cc1/image.png

talbenbasat commented 7 years ago

@mushon

The line from the event marker to the annotation can't surpass the timeline. Since the D3 component is drawing the line.

Which one of these options is better?

talbenbasat commented 7 years ago

daat-annotation1 daat-annotation2

mushon commented 7 years ago

let’s go with the 2nd option (the one without gap)

talbenbasat commented 7 years ago

:+1: