search

daat-hamakom / maps

Da'at Hamakom Frontend Map Interface
Other
0 stars 0 forks source link

Timeline zoom and pan should be limited in years #230

Open mushon opened 7 years ago

mushon commented 7 years ago

Currently you can zoom and pan into timespans that are completely irrelevant to the researches. I think we should set boundaries to the timeline like 1000-2020 or even -3000-2050 or something dynamic like [first event -5 0yr] - [last event + 50yrs]. Right now the options to scroll beyond looks like a mistake. @josefspr your call.

uploads/397ad79a-a34b-4291-ae4c-3a5b6b75b815/image.png

josefspr commented 7 years ago

@talbenbasat, the important part is to set the zoom right for the events after 1750. The space in the future is what looks bad, the early events are less a problem, I mind less if there is space in the past. I assume that the definition should if something like if (t > 1750) zoom = zoom / [(now-t) * a] “now” could be latest event etc.. That means that the zoom depends how close the event is to the edge. If it is close the zoom is higher and the opposite. Just have to play with it to get the factor (a) that looks ok. Also reminding that we don't do anything when clicking on the timeline, so all this is not applicable when we click on timeline.

talbenbasat commented 7 years ago

@josefspr ,

This is conflicting with center event function

What should we do then

josefspr commented 7 years ago

why ? we only center events on timeline when clicking on map