search

daattali / beautiful-jekyll

✨ Build a beautiful and simple website in literally minutes. Demo at https://beautifuljekyll.com
https://beautifuljekyll.com
MIT License
5.4k stars 16.27k forks source link

share buttons not working #126

Closed yimingli closed 8 years ago

yimingli commented 8 years ago

I might be missing something, but it seems that none of the demo blog posts shows share buttons, when in the default front matter social-share: true.

daattali commented 8 years ago

I'm not sure why you think that, I just forked this repo and I do see the social sharing buttons

http://imgur.com/a/kxe13

https://daattalitest.github.io/2015-02-20-test-markdown/

Maybe you're referring to something else. The social-share buttons are the twitter/facebook/linkedin square buttons beneath a post , above the pagination

yimingli commented 8 years ago

Thanks! I was referring to demo blog posts such as this one: http://deanattali.com/beautiful-jekyll/2015-02-26-flake-it-till-you-make-it/ Is this post based on beautiful-jekyll?

I also tried to incorporate social share buttons into jekyll's default theme to no avail. I added /_includes/social_share.html, edited _config.yml and _layouts/post.html, but it didn't work. Could you please point me to the right direction? What other site files should I modify? Thanks a lot!

daattali commented 8 years ago

Oh I see. The demo website is built with a very outdated version before I added support for those buttons.

Honestly I don't remember exactly where all the moving pieces are, it'll take me time to figure that out again and I'm working on a lot of projects and don't really have that time, sorry! On Nov 10, 2016 12:45 PM, "Yiming (Paul) Li" notifications@github.com wrote:

Thanks! I was referring to demo blog posts such as this one: http://deanattali.com/beautiful-jekyll/2015-02-26- flake-it-till-you-make-it/ Is this post based on beautiful-jekyll?

I also tried to incorporate social share buttons into jekyll's default theme to no avail. I added /_includes/social_share.html, edited _config.yml and _layouts/post.html, but it didn't work. Could you please point me to the right direction? What other site files should I modify? Thanks a lot!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/daattali/beautiful-jekyll/issues/126#issuecomment-259757764, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6IFHW1CjWPRibapJ2RV2KHXD3jGjvpks5q81g_gaJpZM4Ku4oh .

yimingli commented 8 years ago

No worries, great theme! Thanks.