upgrade front awesome version 5

[allan9595]

Hello, i try to add discord font awesome on my site but seems like Beautiful jekyll still use font awesome version 4 so my discord icon not works. Could you update it to version 5 for font awesome?

[daattali]

Sure I can look into that when I have a few minutes. I would also accept a pull request

On Feb 20, 2018 4:32 PM, "Allan Chang (bohan)" notifications@github.com wrote:

Hello, i try to add discord font awesome on my site but seems like Beautiful jekyll still use font awesome version 4 so my discord icon not works. Could you update it to version 5 for font awesome?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/daattali/beautiful-jekyll/issues/324, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6IFLco6WR-JT1FI9AsJvuH4SPZWCsTks5tWznrgaJpZM4SMs2y .

[allan9595]

Thank you !

[daattali]

Looks like this will have to wait a bit. fontawesome just released version 5.0.6 17 days ago, and it looks like the CDNs serving fontawesome haven't updated yet (which I totally understand if it's only been 17 days). I checked https://www.bootstrapcdn.com/fontawesome/ and https://cdnjs.com/libraries/font-awesome both of them are still serving 4.x

I'll check again periodically and update when it's available. In the meantime feel free to change it locally on your project to the new version by actually downloading the fontawesome files and referring to the local copy rather than to an online copy

[shyd]

I have done this in my fork in order to use the docker icon 🐳 But I use gulp task runner with bower to build my site. https://schuett.io I will create a PR with the icon changes later. Then you can merge it if v5 becomes available at CDNs.

Cheers

[OCram85]

@shyd: Awesome Blog! Super Arbeit :+1:

[allan9595]

@shyd Do you still able to use the rss feed after you updated to the font awesome 5? My site runs into a rss feed issue now. (https://untcybersecurity.com/feed.xml)

[shyd]

@allan9595 Yes, it's stable for me. I just branched my feature branch into gh-pages for demonstration: https://shyd.github.io/beautiful-jekyll/feed.xml

[andreas-paul]

Is there any update on the migration to Font Awesome v5? I tried to implement it myself but I can't get the icons of v5 to work. Seems like the cdn's are still on v4 which is quite strange.

[daattali]

Not going to be implemented until I have a good reason to

On Sep 13, 2018 05:06, "Andreas Paul" notifications@github.com wrote:

Is there any update on the migration to Font Awesome v5? I tried to implement it myself but I can't get the icons of v5 to work. Seems like the cdn's are still on v4 which is quite strange.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/daattali/beautiful-jekyll/issues/324#issuecomment-420937261, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6IFNhqeqAJtMvcOtL8yIDJzKsfIcbHks5uah_3gaJpZM4SMs2y .

[daattali]

You can look at this PR by @shyd if you want to upgrade!

[daattali]

Done