search

daattali / colourpicker

🎨 A colour picker tool for Shiny and for selecting colours in plots (in R)
https://daattali.com/shiny/colourInput/
Other
217 stars 28 forks source link

Adding alpha and name entry #12

Closed DavidRGriswold closed 7 years ago

DavidRGriswold commented 7 years ago

Can consider this a solution to issue #10 and issue #11

You'll need to do some work on your end to update docs, etc.

daattali commented 7 years ago

I'm assuming this is using the code from after the hotfix to the plugin? I'll wait to merge the plugin and know that it's done before merging into shiny

DavidRGriswold commented 7 years ago

Yes, this is the latest post hotfix code. Just had a minute to get it started.

On Jun 13, 2017 10:49, "Dean Attali" notifications@github.com wrote:

I'm assuming this is using the code from after the hotfix to the plugin? I'll wait to merge the plugin and know that it's done before merging into shiny

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/pull/12#issuecomment-308157355, or mute the thread https://github.com/notifications/unsubscribe-auth/ATpU71_yPBm_pGSVC3c17bVtNii9LxDMks5sDqx1gaJpZM4N4qah .

daattali commented 7 years ago

Thanks The build is still failing for some reason. I can look into it if you have to check out. Thanks for the work

DavidRGriswold commented 7 years ago

I am not sure what that means. It builds fine for me in r studio.

On Jun 18, 2017 10:45, "Dean Attali" notifications@github.com wrote:

Thanks The build is still failing for some reason. I can look into it if you have to check out. Thanks for the work

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/pull/12#issuecomment-309285340, or mute the thread https://github.com/notifications/unsubscribe-auth/ATpU75DjZLcwH2l3eGsSItLkatMLcjfwks5sFUYlgaJpZM4N4qah .

daattali commented 7 years ago

By "the build" I mean the travis-ci build. See image below:

image

travis-ci is a way to automatically run all the tests to make sure the package passes CRAN requirements every time a commit is made. It's useful because you generally don't think about running the tests and CRAN checks every time you make a commit, so this happens automatically, and notifies the repository whenever it fails. When it fails, it means that in its current form there are some tests/checks that are failing and must be fixed. You can read about "continuous integration services" for more general info, but I hope my explanation was enough.

I just took a quick look at the build log (by clicking on Details above) which leads you here, and it looks like there are still some places in the code that refer to formatHEX(), which is why it fails

DavidRGriswold commented 7 years ago

Ah. Well I can't look into it today or at least now because my internet is totally down (tech called) and I do all my r coding on a remote rstudio instance.

On Jun 18, 2017 12:30, "Dean Attali" notifications@github.com wrote:

By "the build" I mean the travis-ci build. See image below:

[image: image] https://user-images.githubusercontent.com/952340/27262658-713693d6-5429-11e7-817a-cc4925751949.png

travis-ci is a way to automatically run all the tests to make sure the package passes CRAN requirements every time a commit is made. It's useful because you generally don't think about running the tests and CRAN checks every time you make a commit, so this happens automatically, and notifies the repository whenever it fails. When it fails, it means that in its current form there are some tests/checks that are failing and must be fixed. You can read about "continuous integration services" for more general info, but I hope my explanation was enough.

I just took a quick look at the build log (by clicking on Details above) which leads you here https://travis-ci.org/daattali/colourpicker/builds/244216106?utm_source=github_status&utm_medium=notification, and it looks like there are still some places in the code that refer to formatHEX(), which is why it fails

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/pull/12#issuecomment-309291103, or mute the thread https://github.com/notifications/unsubscribe-auth/ATpU7x6RO1HdenOYWYb-LiuaYR_O_IZfks5sFV6_gaJpZM4N4qah .

daattali commented 7 years ago

I'm merging this into a separate feature branch so that one of us will continue fixing it after