daattali / colourpicker

🎨 A colour picker tool for Shiny and for selecting colours in plots (in R)
https://daattali.com/shiny/colourInput/
Other
217 stars 28 forks source link

Alpha feature bug: using any rgb/rgba/hsl/hsla values in 'allowedCols' results in multiple swatches created #14

Closed daattali closed 7 years ago

daattali commented 7 years ago

For example:

colourInput("col", "colour", "yellow", palette = "limited",
  allowedCols = c("red", "yellow", "rgb(0, 0, 255)"))

creates a few empty wrong swatches

image

@DavidRGriswold perhaps you know something about this?

DavidRGriswold commented 7 years ago

I will be able to look into this today.

On Jun 25, 2017 23:41, "Dean Attali" notifications@github.com wrote:

For example:

colourInput("col", "colour", "yellow", palette = "limited", allowedCols = c("red", "yellow", "rgb(0, 0, 255)"))

creates a few empty wrong swatches

@DavidRGriswold https://github.com/davidrgriswold perhaps you know something about this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/ATpU7-goq1MOfNbPM5SCpueOsCidicvTks5sHzaGgaJpZM4OE3k7 .

daattali commented 7 years ago

It's solved, thanks! (Haven't pushed yet) On Jun 26, 2017 07:48, "DavidRGriswold" notifications@github.com wrote:

I will be able to look into this today.

On Jun 25, 2017 23:41, "Dean Attali" notifications@github.com wrote:

For example:

colourInput("col", "colour", "yellow", palette = "limited", allowedCols = c("red", "yellow", "rgb(0, 0, 255)"))

creates a few empty wrong swatches

@DavidRGriswold https://github.com/davidrgriswold perhaps you know something about this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/ATpU7- goq1MOfNbPM5SCpueOsCidicvTks5sHzaGgaJpZM4OE3k7 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/daattali/colourpicker/issues/14#issuecomment-311037050, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6IFN7FiJJ80jhLdhABgGsLY9iIwrDSks5sH5qggaJpZM4OE3k7 .