Updates the expected figs under the latest version of ggplot2 (small changes to the figs)
Uses the same function that vdiffr uses to create file paths from plot titles (str_standardise ). Some of our tests were getting skipped b/c of small differences in the file paths, making vdiffr think that the expected fig didn't exist yet. Using the same fun that vidffr uses to create the expected fig paths ensures this won't happen in the future.
Turns skipped tests into failing tests, so the problem mentioned above doesn't happen again.
Fixes a gnarly bug that was stemming from using a global variable (utils::globalVariables("var")).
daattali
commented
6 years ago
This PR:
vdiffruses to create file paths from plot titles (str_standardise). Some of our tests were getting skipped b/c of small differences in the file paths, making vdiffr think that the expected fig didn't exist yet. Using the same fun that vidffr uses to create the expected fig paths ensures this won't happen in the future.utils::globalVariables("var")).