daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements

http://daattali.com/shiny/ggExtra-ggMarginal-demo/

Other

383 stars 45 forks source link

Refactor ggextra #121

Closed crew102 closed 6 years ago

crew102 commented 6 years ago

This PR does some minor refactoring of ggExtra. Highlights include using positional params instead of keyword params (I changed this b/c I thought it would make the code easier to read moving forward) and dropping addMainTheme() (theme_blank() used in its place).

This PR has commits from #120 (commits 21ac7d1 - a0ce24d.)..I'll rebase once #120 is merged.

daattali commented 6 years ago

120 is merged :)

crew102 commented 6 years ago

this is ready to go

daattali commented 6 years ago

Thanks, I'll take a look hopefully on the weekend

daattali commented 6 years ago

OK not a hard PR to review -- but it's hard for me to wrap my head around the fact that theme_void() can be a dropin replacement for a whole custom function! I'll have to test

daattali commented 6 years ago

You're right, it does indeed work when I try modifying the theme, it still keeps it intact.