daattali
commented
8 years ago Thank you, I had no idea how to do this! I really appreciate the help. I have a few comments about the code:
- Can you change all the
->assignments to<-(to match the coding style of the rest of the code) - Similarly, just to be consistent with the rest of the code, can all if statements have curly braces and start the expression on a new line, even if it's a one-liner
- I prefer not to use
exists("lgnd_grob")and instead do something like initialize lgnd_grob to NULL and check if its not NULL, because right now if the variable exists on the user's global env it will cause problems (that shouldn't really happen, it'd be a huge coincidence, but it just feels safer not to useexists()) - Regarding your question: I'm not sure about older versions. If needed, you can add some check in the code
if (utils::packageVersion("ggplot2") >= "2.0.0")if you don't think this'll work for older versions
The last comment is not about the code: I see you chose to move the legend to the bottom even though by default plots will have the legend on the right. I understand that choice, because this way the marginal plots are right beside the plot, but I feel like that's not the correct thing to do. If I pass in a plot object to ggMarginal , I expect to get back the exact same plot as the main plot, without having its legend position changed. Do you think you could respect the legend location?
crew102
legend.position = "none"is the syntax used in old versions of ggplot2. Do you happen to know off hand? If it isn't, then then the fix may not work for some users.