search

daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements
http://daattali.com/shiny/ggExtra-ggMarginal-demo/
Other
383 stars 45 forks source link

Regression in getVarDF #71

Closed crew102 closed 7 years ago

crew102 commented 7 years ago

Looks like I introduced a bug when fixing #67. The following code now doesn't run during testing due to the new bug:

library(ggplot2)
library(ggExtra)

p <- ggplot(data = mtcars) +
  geom_point(aes(x = wt, y = drat, colour = gear)) +
  ggtitle("pretty sweet title",
                   subtitle = "not a bad subtitle either") +
  theme(plot.title = element_text(colour = "red"))

ggMarginal(p = p)

PR on the way.

daattali commented 7 years ago

Is this the reason for the failing tests on travis now (that have always been failing but maybe now they'd pass)? Anyway, thanks for catching that

crew102 commented 7 years ago

looking into it now

daattali commented 7 years ago

travis will inform us soon enough https://travis-ci.org/daattali/ggExtra/builds/286744817