Refactor ggMarginal to use R6

daattali / ggExtra

📊 Add marginal histograms to ggplot2, and more ggplot2 enhancements

http://daattali.com/shiny/ggExtra-ggMarginal-demo/

Other

380 stars 48 forks source link

Refactor ggMarginal to use R6 #90

Closed crew102 closed 5 years ago

crew102 commented 6 years ago

I think ggMarginal needs another refactoring. Would you be amenable to ggExtra importing R6 if I wanted to use it when re-working ggMarginal?

Also needs more thorough commenting throughout code (which I've been neglecting), given how much seemingly random stuff happens in ggMarginal.

daattali commented 6 years ago

R6 is pretty good and lightweight, so there's nothing against it. What would be the main benefit, to save state so that there aren't a ton of variables being constantly passed around?

crew102 commented 6 years ago

Yep, exactly

daattali commented 6 years ago

Sure!