daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

White on white buttons with dark reader #11

Closed SuperSandro2000 closed 4 years ago

SuperSandro2000 commented 4 years ago

When using this extensions in combination with dark reader some button are white on white.

image

daattali commented 4 years ago

I don't know what the dark reader does but this seems to be some css that the dark reader causes.

I can only support the native github experience, I can't make it work with 3rd party decorators

SuperSandro2000 commented 4 years ago

This is the first time I saw such case and all other extensions that enhance github or any site never had such issues so I don't think it is Dark Readers fault but this extension doing something unexptected.

daattali commented 4 years ago

I'm forcing the background colour of the buttons to be light grey. It looks like your dark extension is forcing the font colour to be white. That's what I assume is happening.

daattali commented 4 years ago

I tried installing Dark Reader and indeed that's what's happening.

I tried a few things to work around that, but there doesn't seem to be a generic way to make it work across all buttons.

I'll add this so that it fixes many buttons, but not all. Look at the screenshot below, the items on this page are fine

image

But some buttons like the "filter" button here get specific CSS from the dark mode theme that are specific to that button and I cannot override them

image

Also note that the line under the tabs is grey on the sides and black in the middle. The dark reader extension doesn't add any CSS classes to the page's HTML so I can't easily tell whether or not the dark reader is on or off. So this is the best I can do while still staying generic.

daattali commented 4 years ago

Solved