Wider comment forms

[szepeviktor]

Thank you for reverting some design updates.

Do you plan to make the comment form smaller again?

[daattali]

Was it smaller before? Please show me the difference before and after. I don't recall that being different.

[szepeviktor]

Current size

[daattali]

Was it smaller before? I can see what it looks like now, but I don't have any reference to see if it was smaller before. If you can show me hwo it looked before that would help.

[szepeviktor]

You must know the 600px rule. It is the biggest width which can be read easily.

.container-xl {
    max-width: 970px;
}

Now the comment form is 600 px :)

[szepeviktor]

Actually it was 700px: https://guides.github.com/features/issues/example-issue.png But I like 600 better :)

[daattali]

If you have away to see exactly what it looked like previously, I can look into it. From that screenshot I can't really gather too much information. For all the other work I've done here, I used waybackmachine to see exactly how things looked

[szepeviktor]

I used waybackmachine to see exactly how things looked

That is wise.

Yes, in the old times the comment form was exactly 700px wide

https://web.archive.org/web/20190512205747/https://github.com/Homebrew/brew/pull/1

[szepeviktor]

With the avatar:

.discussion-timeline {
    width: 760px;
}

[daattali]

That looks like the entire page layout is different, not just the style of one item. As the Limitations section in the README says, I can't reliably change the layout without inadvertedly affecting other pieces of the page. Unfortunately I don't think this will be handled here.

[szepeviktor]

Thank you.

Does you extension have options? Maybe it would be possible to handle this with disabled as default.

[zekefarwell]

I just put a max-width and margin: auto on the comment column and it looks pretty decent. It is out of alignment with the overall page width though, so I won't pursue and test this further if @daattali feels it's out of scope for this extension.

...

[daattali]

@szepeviktor That's a good idea, to introduce options so that you can choose to opt-in/out of certain features!

[zekefarwell]

A nice idea, but definitely would increase the maintenance burden

[daattali]

I don't like that the entire page's alignment changes, and not for the better, because of this. So I don't think I want to include that as a default.

But if there are opt-in options then it could be added. I opened an issue for that #16

[szepeviktor]

Okay.

[daattali]

If #16 ends up being implemented (big if), then this issue is already linked there and will be addressed