daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

Can i have a square buttons instead of circles one ;-; #15

Closed mkcoldwolf closed 4 years ago

mkcoldwolf commented 4 years ago

AS title ;-; , my CSS is too trash to contribute image Radius of those button are not that sick on the old school github

zekefarwell commented 4 years ago

There were some commits that set the button border radius back to the same as the classic UI. It had some unintended side effects though so it had to be reverted. It may be possible to do it in a more targeted way though.

daattali commented 4 years ago

@zekefarwell is correct.

There are a lot of buttons and they're used in many contexts in a variety of ways. After setting the button radius,I wasn't trying to look for issues but I accidentally ran into a few issues (there are probably even more if I tried looking for them):

The annoying thing is that github didn't think about making these buttons share CSS classes, do they can't be handled nicely generically. You would have to find ALL the buttons in the site and make sure to target each one.

Unfortunately I don't think that's a good idea

zekefarwell commented 4 years ago

@mkcoldwolf, a solution for classic, more square buttons was implemented in #22