search

daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

Consider adding options popup to opt in/out of features #16

Closed daattali closed 4 years ago

daattali commented 4 years ago

I've played around with an options popup several years ago here (I don't know if it works out of the box for both Chrome and FF, I hope it does).

This would add a whole new layer of complexity to the extension from a coding/maintenance perspective.

I'm also not sure how to conditionally show CSS based on which options are set. Perhaps using javascript, a CSS class or attribute can be added to the body tag, and then all the CSS rules will only be applied if their matching body rule is present.

I have to get back to actually paying my bills but this is an idea to keep open.

daattali commented 4 years ago

The more I think about this, the more I think it will add a lot of headache :)

But if there are enough important features that have a good reason to go into an opt-in/opt-out system then it might be worthwhile.

Implementing a settings page: FireFox, Chrome

daattali commented 4 years ago

I don't see too much use for this. The only isue so far that was a candidate is having wider comment forms, and I don't think that warrants doing all this extra work. Closing for now