search

daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

Border Radius: Old 3px vs New 6px? #19

Closed zekefarwell closed 4 years ago

zekefarwell commented 4 years ago

This extension reverts some elements to the old 3px border radius while leaving lots of others at 6px which makes things look a little inconsistent. I've made some good progress reverting buttons and other elements to 3px without too many more lines of css, however the more I look at the wayback machine, the more I realize just how many elements were changed from 6px border radius to 3px that will need to be changed for consistent look.

Personally, although I prefer the old 3px radius, I don't absolutely hate the new 6px radius. The inconsistency of some boxes being reverted to 3px while the rest are 6px does bother me though. I think this extension should choose either 3px or 6px radius and stick with it. If the goal is to be as close as possible to classic github with 3px border radius, I will help achieve that with minimal css. If you want to stick with 6px, I think that's sensible too.

daattali commented 4 years ago

The goal is 3. Are there many places that still use 6, except for the buttons? I'd be happy to make the buttons 3 as well, but that would require fixing all the buttons across github, which isn't a small task

zekefarwell commented 4 years ago

Cool. Happy to help with reverting to 3px border radius. Buttons, labels, form fields, search boxes, avatars, navbars, pagination, and various other boxes are all 6px in the new design and were 3px in the old. It's definitely a lot of elements, but I think it can be done carefully with css rules that are neither too broad or too specific.

Here are some screenshots from the wayback machine showing a variety of things with 3px border radius. I'm sure there are more. Many items in all the settings pages for example. Those are hard (impossible?) to see on the wayback machine though.

Screen Shot 2020-06-27 at 1 18 57 PM Screen Shot 2020-06-27 at 1 18 40 PM Screen Shot 2020-06-27 at 1 16 41 PM Screen Shot 2020-06-27 at 1 16 25 PM

I've got some uncommitted changes on my fork that set most of the buttons to 3px without breaking the look of the button groups (split buttons with straight line in between). I'll submit a PR at some point when it gets to a good place.

daattali commented 4 years ago

Sounds good :)

daattali commented 4 years ago

I'm closing this issue as you've already addressed most places. The few remaining 6px can be addressed separately