daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

Add user style version #31

Closed kidonng closed 4 years ago

kidonng commented 4 years ago

Close #30

daattali commented 4 years ago

Will I need to explicitly provide a github token to the Github Actions job?

kidonng commented 4 years ago

No, it is automatically created, see https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token.

daattali commented 4 years ago

Thanks a lot, this is great.

I changed the action to trigger when the manifest is updated so that it only happens when the version is bumped.

Is there a reason you made the version {version}.0 instead of just {version}?

kidonng commented 4 years ago

I changed the action to trigger when the manifest is updated

That makes sense 👍

Is there a reason you made the version {version}.0 instead of just {version}?

https://github.com/daattali/oldschool-github-extension/blob/master/generate-user-style.js#L6

If the user style doesn't comply with SemVer then it can't be installed.

kidonng commented 4 years ago

If the manifest version is following SemVer I think that line can be dropped.

daattali commented 4 years ago

Thanks. I'll use semantic versioning more strictly then, and remove the extra 0

89649155050 commented 3 years ago

#

89649155050 commented 3 years ago

26