Closed kidonng closed 4 years ago
Will I need to explicitly provide a github token to the Github Actions job?
No, it is automatically created, see https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token.
Thanks a lot, this is great.
I changed the action to trigger when the manifest is updated so that it only happens when the version is bumped.
Is there a reason you made the version {version}.0
instead of just {version}
?
I changed the action to trigger when the manifest is updated
That makes sense 👍
Is there a reason you made the version
{version}.0
instead of just{version}
?
https://github.com/daattali/oldschool-github-extension/blob/master/generate-user-style.js#L6
If the user style doesn't comply with SemVer then it can't be installed.
If the manifest version is following SemVer I think that line can be dropped.
Thanks. I'll use semantic versioning more strictly then, and remove the extra 0
#
Close #30
osgh.css