search

daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

[BUG] Some buttons are WHITE in new dark mode #39

Open TheTechRobo opened 3 years ago

TheTechRobo commented 3 years ago

image

image

Debugged, and this is due to old school github.

zekefarwell commented 3 years ago

I suppose we'll have to see if @daattali wants to support the new dark mode or not. This project was started with the goal of reverting the look of github back to how it was prior to June 23, 2020. Dark mode did not exist at that time so supporting dark mode would be a scope expansion.

szepeviktor commented 3 years ago

These round UI elements feel so microsofty, not the goodold githuby :)

TheTechRobo commented 3 years ago

@zekefarwell Good point

@szepeviktor Also good point

daattali commented 3 years ago

Thanks for reporting @TheTechRobo and thanks for chiming in @zekefarwell

It's a good point that dark mode didn't exist before so technically it is a scope expansion, but I'm not at all opposed to trying to support dark mode as well since it will only involve css colour changes. I haven't had a chance yet to test out dark mode myself, I hope that github simply adds some CSS class to a top level element, which would make it fairly simple to support dark mode.

TheTechRobo commented 3 years ago

Here's something that may be of use : https://github.community/t/an-easy-api-to-use-to-detect-current-dark-white-mode/149406

daattali commented 3 years ago

Looks like it can be simpler than that, the html node has an attribute data-color-mode="dark"

szepeviktor commented 3 years ago

@daattali Please consider that data-color-mode="auto" is also dark when the browser/OS is set to dark mode.

szepeviktor commented 3 years ago

In @primer/css/core GitHub has @media (prefers-color-scheme:light){ ... }

daattali commented 3 years ago

Ah very good point thank you!

On Sat., Dec. 12, 2020, 17:53 Viktor Szépe, notifications@github.com wrote:

In @primer/css/core https://github.githubassets.com/assets/frameworks-color-modes-88d9d48f19c365bc761aa9de492cc616.css GitHub has @media (prefers-color-scheme:light){ ... }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daattali/oldschool-github-extension/issues/39#issuecomment-743916472, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHIQFHPG4AWOLIHHJA6NJ3SUPX43ANCNFSM4UTVS6MQ .