daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).
https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb
MIT License
229 stars 11 forks source link

Remove rounded edges #4

Closed InfamousStarFox closed 4 years ago

InfamousStarFox commented 4 years ago

Limited .Box css changes to the .repository-content class

daattali commented 4 years ago

Thanks for the PR, I was trying to avoid doing any rule on something this general because I don't know all the consequences of it (all the places it's used). Which items exactly does this fix, which boxes?

InfamousStarFox commented 4 years ago

Square Attached is a screenshot of how it would affect the box corners. Let me make a change to limit the scope to just repository-content boxes

daattali commented 4 years ago

It looks like this completely removes any roundedness. I used waybackmachine to see how github looked before, and there was rounded corners still.

Sorry to be so pedantic, but if we touch the rounded corners, I'd want to make them match the pre-update look to go along with this extension's theme, not do something different :)

InfamousStarFox commented 4 years ago

Hmm, I was going off of memory. Looks like the old radius was 3px, and the new radius is 6px

daattali commented 4 years ago

I don't think Box-header should have rounded edges on all 4 corners, only the top two. Do you agree?

InfamousStarFox commented 4 years ago

Yes, I agree. I have updated the css to match

daattali commented 4 years ago

Are all the !important absolutely necessary?

InfamousStarFox commented 4 years ago

No, not all of them. I have removed the extraneous !important tags now

daattali commented 4 years ago

Thanks!

daattali commented 4 years ago

@InfamousStarFox I'm going to have to revert the button padding. It causes some issues, and it's going to be extremely difficult to test out all the places buttons are used and fix them all.

For example

image

and

image

and

image