[Req] Bring the contents of the black bar in line with the contents of pages

daattali / oldschool-github-extension

Revert GitHub's UI back to its classic look (before the June 23, 2020 update that has a flat, rounded and more whitespaced design).

https://chrome.google.com/webstore/detail/old-school-github/blkkkhifjoiedclojflfcenbjigdajeb

MIT License

229 stars 11 forks source link

[Req] Bring the contents of the black bar in line with the contents of pages #9

Closed karai17 closed 4 years ago

karai17 commented 4 years ago

Like with the new left-aligned tabs, the black bar being full-width is pretty much horrible. If you could apply a rule to make the contents of the black bar also centred properly, that would be swell. Pictured below: the page looks passable at 200% scale!

daattali commented 4 years ago

How did the black bar look before the update? I would look into this if the black bar now doesn't match what it was like a week ago

karai17 commented 4 years ago

I don't think it changed with this update, it's just been horrible since they updated the front page.

daattali commented 4 years ago

If it's not something that changed with the new update, I prefer not to touch it. This extension is explicitly for issues that arose this week, not for fixing other UI because then we get into personal taste :)

karai17 commented 4 years ago

I can understand that. However, I think that this request is in line with one of the major frustrations with this latest update in that the contents of the page shouldn't be aligned to the far edges of the screen. Bringing all of the content within the 1200px centre would be a marked improvement.

daattali commented 4 years ago

I really don't want to fiddle with anything that wasn't in the UI before.

Another example is the file list: in tables with many rows like the file list, it's nice to have alternating rows have slightly different backgrounds. But I did not implement that even though I think it's better because the clear purpose here is to simply try to revert as much as possible the June update, not to impose any subjective design decisions. I agree that a narrower top bar would be better, but I don't want to make any exceptions to the goal of this extension, because from there it will easily snowball into more exceptions.

zekefarwell commented 4 years ago

Can confirm that the black bar at the top was full width before the June 23rd.

EbNkjBTU8AA2JMx Source: https://twitter.com/KevBurnsJr/status/1275475187064909824

However, the black bar was only full width when signed in. When signed out, the black bar matched the content width:

aaand it still matches the content width when signed out in the new design – so bizarre:

I agree it's probably best to stick as close as possible to how things were before 6/23. Just documenting here for future reference.

daattali commented 4 years ago

Thanks for pointing this out. Definitely some questionable decisions by GitHub there, but fixing old problems is out of scope.