daattali / shinyalert

🗯️ Easily create pretty popup messages (modals) in Shiny
https://daattali.com/shiny/shinyalert-demo/
Other
241 stars 26 forks source link

useShinyAlert() is required with v. 2.0.0 #58

Closed gueyenono closed 3 years ago

gueyenono commented 3 years ago

I just installed the latest version of shinyalert and it seems that including useShinyAlert() in the UI is required again. This is not really an issue; however, it is important to know because the examples in the Readme do not work currently.

daattali commented 3 years ago

Shiny apps do not need to call useShinyalert() in the ui.

If you think there's an issue with that, please post an example.

daattali commented 3 years ago

Oh, I think you mean the latest CRAN version does not support that yet. That's correct. The README on github is up to date with the github version. The documentation on the CRAN version is correct for the CRAN version.

Closing this issue as I think it's fine for the github documentation to be up to date with its own version of the code.